Messages in this thread |  | | Date | Tue, 10 Jun 2003 17:02:05 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] loop 2/9 absorb bio_copy |
| |
On Tue, 10 Jun 2003, Jens Axboe wrote: > On Tue, Jun 10 2003, Hugh Dickins wrote: > > bio_copy is used only by the loop driver, which already has to walk the > > bio segments itself: so it makes sense to change it from bio.c export > > to loop.c static, as prelude to working upon it there. > > I don't think this is is a particularly good idea, it's pretty core bio > functionality that should be left alone in bio.c imho. > > Is there a real reason you want to do this apart from 'loop is the only > (current) user'?
As I said, loop already has to walk the bio segments itself elsewhere, and a lot of what bio_copy does (e.g. copying data) it doesn't need done, and other things it does (same gfp_mask for two very different allocations) don't suit loop very well. By all means add bio_copy back into fs/bio.c when something else needs that functionality?
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |