Messages in this thread |  | | Date | Tue, 10 Jun 2003 08:36:38 -0700 | From | george anzinger <> | Subject | Re: [PATCH] Some clean up of the time code. |
| |
Andrew Morton wrote: > george anzinger <george@mvista.com> wrote: > >>-void do_settimeofday(struct timeval *tv) >> +int do_settimeofday(struct timespec *tv) >> { >> + if ((unsigned long)tv->tv_nsec > NSEC_PER_SEC) >> + return -EINVAL; >> + > > > Should that be ">="? > > Is there any reasonable way to avoid breaking existing > do_settimeofday() implementations? That's just more grief all round.
Hm. Giving this more thought, the main reason for the change was to move to the timespec from the timeval, i.e. nanoseconds instead of microseconds. The error check was put in because the function was already being changed. The reason to move to the timespec is to complete the change made to xtime and to more correctly align with the POSIX clock_settime, both of which use timespec.
I suspect Linus would prefer this direction...
Comments? > >
-- George Anzinger george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |