Messages in this thread | | | Date | Thu, 8 May 2003 06:06:40 +0100 | From | Christoph Hellwig <> | Subject | Re: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one() |
| |
On Thu, May 08, 2003 at 01:01:46AM +0200, Francois Romieu wrote: > #if LINUX_VERSION_CODE > KERNEL_VERSION(2,3,43) > - if (pci_enable_device(pci_dev)) return -EIO; > + if (pci_enable_device(pci_dev)) > + goto out; > #endif
Btw, this driver badly wants a cleanup of the ifdef mess. Look at some network drivers on how to support older kenrels nicely wiþh not much more than a compat layer header instead of spreading ifdefs all over the place. Who reviewed this driver before inclusion?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |