lkml.org 
[lkml]   [2003]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one()
On Thu, May 08, 2003 at 01:01:46AM +0200, Francois Romieu wrote:
> #if LINUX_VERSION_CODE > KERNEL_VERSION(2,3,43)
> - if (pci_enable_device(pci_dev)) return -EIO;
> + if (pci_enable_device(pci_dev))
> + goto out;
> #endif

Btw, this driver badly wants a cleanup of the ifdef mess. Look
at some network drivers on how to support older kenrels nicely
wiþh not much more than a compat layer header instead of spreading
ifdefs all over the place. Who reviewed this driver before
inclusion?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.044 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site