lkml.org 
[lkml]   [2003]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: oops 2.5.68 ohci1394/ IRQ/acpi
Grover, Andrew wrote:
> Ohhh so we need to not just return nonzero, but return 1 (aka
> IRQ_HANDLED?) Well, then this makes sense. Sorry about that.
>
> btw I think the line in handle_IRQ_event that reads
>
> if (retval != 1) {
>
> should be
>
> if (retval != IRQ_HANDLED) {


Then I must further nit-pick: if IRQ_HANDLED is considered "non-zero"
the above test should be against IRQ_NONE, to avoid directly considering
any single value _the_ non-zero value...

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:1.054 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site