Messages in this thread Patch in this message | | | Subject | Re: [PATCH] include/linux/sunrpc/svc.h compilation error | From | Grzegorz Jaskiewicz <> | Date | 06 May 2003 13:12:01 +0100 |
| |
Sorry for that Linus, patch below is a right one.
diff -r -u 2/include/linux/sunrpc/svc.h 1/include/linux/sunrpc/svc.h --- 2/include/linux/sunrpc/svc.h 2003-05-05 00:53:31.000000000 +0100 +++ 1/include/linux/sunrpc/svc.h 2003-05-06 13:06:27.000000000 +0100 @@ -176,8 +176,14 @@ { if (rqstp->rq_arghi <= rqstp->rq_argused) return -ENOMEM; - rqstp->rq_respages[rqstp->rq_resused++] = - rqstp->rq_argpages[--rqstp->rq_arghi]; + + rqstp->rq_arghi--; + + rqstp->rq_respages[rqstp->rq_resused] = + rqstp->rq_argpages[rqstp->rq_arghi]; + + rqstp->rq_resused++; + return 0; }
On Tue, 2003-05-06 at 13:02, Grzegorz Jaskiewicz wrote: > On Tue, 2003-05-06 at 11:08, Paweł Gołaszewski wrote: > > That kernel fails for me when building... > > [cut] > > > > gcc -Wp,-MD,fs/lockd/.clntproc.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=clntproc -DKBUILD_MODNAME=lockd -c -o fs/lockd/.tmp_clntproc.o fs/lockd/clntproc.c > > In file included from fs/lockd/clntproc.c:17: > > include/linux/sunrpc/svc.h: In function `svc_take_page': > > include/linux/sunrpc/svc.h:180: invalid lvalue in assignment > > make[3]: *** [fs/lockd/clntproc.o] Error 1 > > make[2]: *** [fs/lockd] Error 2 > > make[1]: *** [fs] Error 2 > > make: *** [modules] Error 2 > > Looks like gcc fault, can You Pawel give as gcc version ? > > this patch as reported by Pawel helps: > but still, it looks strange - i am sure it is just an gcc issue -- Grzegorz Jaskiewicz <gj@pointblue.com.pl> K4 labs
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |