Messages in this thread | | | Subject | Re: [RFC] support for sysfs string based properties for SCSI (1/3) | From | James Bottomley <> | Date | 05 May 2003 12:08:35 -0500 |
| |
On Mon, 2003-05-05 at 12:02, Greg KH wrote: > On Sat, May 03, 2003 at 02:19:23PM -0500, James Bottomley wrote: > > diff -Nru a/drivers/base/core.c b/drivers/base/core.c > > --- a/drivers/base/core.c Sat May 3 14:18:21 2003 > > +++ b/drivers/base/core.c Sat May 3 14:18:21 2003 > > @@ -42,6 +42,8 @@ > > > > if (dev_attr->show) > > ret = dev_attr->show(dev,buf); > > + else if (dev->bus->show) > > + ret = dev->bus->show(dev, buf, attr); > > return ret; > > Can't you do this by using the class interface instead?
I don't know, I haven't digested the class interface patches yet, since they just appeared this morning.
> This also forces you to do a lot of string compares within the bus show > function (as your example did) which is almost as unwieldy as just > having individual show functions, right? :)
Nothing prevents users from doing it the callback way. However, callbacks aren't a scaleable interface for properties that have to be shared and overridden.
I agree string compares are unwieldy (and smack of XML), so I'm open to suggestions of a better way of doing it that has the same flexibility of the string method...
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |