Messages in this thread |  | | Date | Mon, 5 May 2003 10:02:02 -0700 | From | Greg KH <> | Subject | Re: [RFC] support for sysfs string based properties for SCSI (1/3) |
| |
On Sat, May 03, 2003 at 02:19:23PM -0500, James Bottomley wrote: > diff -Nru a/drivers/base/core.c b/drivers/base/core.c > --- a/drivers/base/core.c Sat May 3 14:18:21 2003 > +++ b/drivers/base/core.c Sat May 3 14:18:21 2003 > @@ -42,6 +42,8 @@ > > if (dev_attr->show) > ret = dev_attr->show(dev,buf); > + else if (dev->bus->show) > + ret = dev->bus->show(dev, buf, attr); > return ret;
Can't you do this by using the class interface instead?
This also forces you to do a lot of string compares within the bus show function (as your example did) which is almost as unwieldy as just having individual show functions, right? :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |