Messages in this thread |  | | Date | Sat, 31 May 2003 16:39:28 -0700 | From | David Brownell <> | Subject | Re: [2.5 patch] let USB_GADGET depend on USB |
| |
Adrian Bunk wrote: > USB_GADGET is still selectable even with USB disabled. It seems the > following is intended:
This is wrong.
CONFIG_USB has always represented the master/host side ... while CONFIG_USB_GADGET represents just the slave/gadget side.
The two are completely independent. Hardware that supports one will typically _not_ support the other. And systems that support the slave/gadget side will have no use at all for the 100KB+ of "usbcore".
If you want CONFIG_USB_GADGET to depend on USB, then you're going to need to change the meaning of CONFIG_USB so that it becomes just an "umbrella" ... and change EVERYTHING that currently depends on CONFIG_USB to depend on some new config varaible representing just the host side (which also depends on CONFIG_USB). That sort of change seems pointless.
> --- linux-2.5.70-mm3/drivers/usb/gadget/Kconfig.old 2003-06-01 00:15:30.000000000 +0200 > +++ linux-2.5.70-mm3/drivers/usb/gadget/Kconfig 2003-06-01 00:15:49.000000000 +0200 > @@ -8,7 +8,7 @@ > # > menuconfig USB_GADGET > tristate "Support for USB Gadgets" > - depends on EXPERIMENTAL > + depends on USB && EXPERIMENTAL > help > USB is a master/slave protocol, organized with one master > host (such as a PC) controlling up to 127 peripheral devices. > > > > cu > Adrian >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |