Messages in this thread |  | | Subject | Re: [PATCH][ATM] assorted he driver cleanup | Date | Thu, 29 May 2003 14:08:59 -0400 | From | chas williams <> |
| |
In message <20030529162125.GU24054@conectiva.com.br>,Arnaldo Carvalho de Melo w rites: >> @@ -1067,46 +1044,39 @@ >> */ >> >> /* 4.3 pci bus controller-specific initialization */ >> - if (pci_read_config_dword(pci_dev, GEN_CNTL_0, &gen_cntl_0) != 0) >> - { >> + if (pci_read_config_dword(pci_dev, GEN_CNTL_0, &gen_cntl_0) != 0) { >> hprintk("can't read GEN_CNTL_0\n"); > >Humm, shouldn't we release the irq here? What about using gotos for exception >handing?
what irq? the irq is grabbed in he_init_irq. if he_start() fails, we call he_stop() and it frees the irq.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |