Messages in this thread |  | | Date | Thu, 29 May 2003 14:36:37 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH][ATM] assorted he driver cleanup |
| |
Em Thu, May 29, 2003 at 01:12:13PM -0400, chas williams escreveu: > In message <20030529170621.GX24054@conectiva.com.br>,Arnaldo Carvalho de Melo w > rites: > >no, no, I was talking just about the need for HE_SPIN_LOCK wrapper, not the > >locking, i.e. couldn't it be just: > > > >spin_lock_irqsave(&dev->global_lock, flags) > > > >used so that it is clear that it is a irqsave variation, etc? > > i suppose i could change it all back. at one point, he_spin_lock() > was 'optmized' away on non smp machines (since a single cpu doesnt > tickle the particular h/w problem). > > i didnt want a ton of #ifdef CONFIG_SMP in the driver.
Sure thing, but hey, spin_lock_irqsave and friends take care of how to behave when in up or smp, i.e. its how all the other drivers use spinlocks 8)
- Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |