Messages in this thread |  | | Date | Tue, 27 May 2003 05:03:00 -0400 (EDT) | From | Zwane Mwaikambo <> | Subject | Re: [PATCH] ITE_887x parport and serial driver |
| |
On Tue, 27 May 2003 Ted.Wen@ite.com.tw wrote:
> --- parport_serial.c 2002-08-03 08:39:44.000000000 +0800 > +++ parport_serial_887x.c 2003-05-27 14:25:49.000000000 +0800 > @@ -29,8 +29,160 @@ > > #include <asm/serial.h> > > +// ITE8872 ITE8872
I don't mean to nitpick, but please use normal C (I know they are valid C99) comments.
> +int ite8872parportnum,ite8872comnum,ITEBOARDNUMBER; > +u32 ITE8872_INTC[8]; > +u8 ITE8872_IRQ[8]; > + > +void ite8872_requestirq(int irq,void *dev_id,struct pt_regs *regs){
For 2.5 there is now a return value for interrupt handlers (irqreturn_t)
> + result = request_irq(ITE8872_IRQ[ITEBOARDNUMBER],ite8872_requestirq,SA_SHIRQ,"ite8872",pcidev);
Which PCI device function is this for?
> +if ((dev->vendor==0x1283 && dev->device==0x8872) && ite8872comnum == 0) > +return 0; > priv->ser = *board; > if (board->init_fn && ((board->init_fn) (dev, board, 1) != 0)) > return 1; > @@ -308,6 +466,8 @@ > cards[i].preinit_hook (dev, PARPORT_IRQ_NONE, PARPORT_DMA_NONE)) > return -ENODEV; > > +if ((dev->vendor==0x1283 && dev->device==0x8872) && ite8872parportnum == 0) > +return 0; > for (n = 0; n < cards[i].numports; n++) { > struct parport *port; > int lo = cards[i].addr[n].lo;
These exceptions look really ugly, how come you need a custom interrupt handler?
Zwane -- function.linuxpower.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |