Messages in this thread | | | Subject | Re: Resend [PATCH] Make KOBJ_NAME_LEN match BUS_ID_SIZE | From | Valdis.Kletnieks@vt ... | Date | Sun, 25 May 2003 14:13:02 -0400 |
| |
On Sun, 25 May 2003 10:51:02 CDT, Matt Mackall said:
> The return value here isn't particularly useful. The OpenBSD > strlcpy/strlcat variant tell you how big the result should have been > so that you can realloc if need be.
A quick grep of the current source tree seems to indicate that there aren't any uses of 'strncpy' that actually save or check the return value.
As such, actually *using* the return value would make for a job for the kernel janitors, to actually do something useful at all 650 or so uses.
Given that the kernel probably *shouldn't* be trying to strlcpy() into a destination that it won't fit, it may be more useful to do a BUG_ON() or similar (feel free to use a 'goto too_long;' if you prefer ;)
[unhandled content-type:application/pgp-signature] | |