lkml.org 
[lkml]   [2003]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI changes for 2.5.69
On Thu, May 22, 2003 at 03:06:01PM -0700, Greg KH wrote:
> ChangeSet 1.1210, 2003/05/22 10:30:35-07:00, greg@kroah.com
>
> PCI: add pci_get_dev() and pci_put_dev()
>
> Move the PCI core to start using these, enabling proper reference counting
> on struct pci_dev.
>
>
> drivers/pci/bus.c | 2 +-
> drivers/pci/hotplug.c | 2 +-
> drivers/pci/pci-driver.c | 41 +++++++++++++++++++++++++++++++++++++++++
> drivers/pci/probe.c | 18 ++++++++++++++++++
> include/linux/pci.h | 2 ++
> 5 files changed, 63 insertions(+), 2 deletions(-)
>
>
> diff -Nru a/drivers/pci/bus.c b/drivers/pci/bus.c
> --- a/drivers/pci/bus.c Thu May 22 14:50:44 2003
> +++ b/drivers/pci/bus.c Thu May 22 14:50:44 2003
> @@ -92,7 +92,7 @@
> if (!list_empty(&dev->global_list))
> continue;
>
> - device_register(&dev->dev);
> + device_add(&dev->dev);

This doesn't match the patch description..

> +struct pci_dev *pci_get_dev (struct pci_dev *dev)

Please fix up to adhere Documentation/CodingStyle (hint: placement
of the opening brace is wrong).

> +{
> + struct device *tmp;
> +
> + if (!dev)
> + return NULL;

Does it make sense to allow NULL argument here?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2011 Jasper Spaans