lkml.org 
[lkml]   [2003]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] cache flush bug in mm/filemap.c (all kernels >= 2.5.30(at least))
    From
    Date
    On Thu, 2003-05-22 at 07:11, Russell King wrote:
    > We seem to have flush_icache_page() in install_page() - I wonder whether
    > we should also have flush_dcache_page() in there as well.
    ...
    > Maybe someone more knowledgeable of the VM layer can comment.

    I am not sure of the exact environment install_page() is meant
    to run in, does it always know that no mapping exists at that
    address?

    If not, something (either there or higher up) needs to be doing
    a flush_cache_page(...) at a minimum.

    The things that some platforms use flush_icache_page() for are
    handled by other platforms using other mechanisms in clever ways (for
    example, at update_mmu_cache() or instruction TLB miss time, older
    sparc64's use special D/I cache flush block stores to handle the I-cache
    coherency problem there).

    --
    David S. Miller <davem@redhat.com>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:3.222 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site