lkml.org 
[lkml]   [2003]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [BUGS] 2.5.69 syncppp
    Date
    > sppp_lcp_open() is called from other places
    > without that lock held, so it is probably not
    > totally stupid to drop it in the timer handler too.

    That section was previously covered by cli/sti,
    and I changed it to use the spinlock instead
    when cli/sti went away in 2.5.x.

    I thought it was in place to serialize state changes.
    I'll look at it harder, you may be right in that
    it is not necessary.

    > It's good (and surprising) that someone is
    > actually using that stuff.

    It's not pretty, but it works.
    Some customers prefer it to pppd.

    > Please beat on it for a while.

    Yes, that code is in need of a good beating :-)

    Paul Fulghum
    paulkf@microgate.com


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:0.020 / U:62.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site