Messages in this thread Patch in this message | | | From | Duncan Sands <> | Subject | Re: Use of sti in entry.S question | Date | Thu, 22 May 2003 22:48:44 +0200 |
| |
... > > Is this a mistake or an optimization? Elsewhere in entry.S, interrupts > > are turned on before calling schedule: > > It's a mistake, but a harmless one. The scheduler turns off interrupts > soon itself and the instructions it executes before that don't care. > The only reason it's not recommended to call schedule with interrupts > off is that the scheduler will turn them on again, usually breaking > your critical section. In this case it's ok because the next > instrution is a cli again.
Do you think it's worth pushing this fix?
diff -Nru a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S --- a/arch/i386/kernel/entry.S Thu May 22 22:45:50 2003 +++ b/arch/i386/kernel/entry.S Thu May 22 22:45:50 2003 @@ -306,6 +306,7 @@ testb $_TIF_NEED_RESCHED, %cl jz work_notifysig work_resched: + sti call schedule cli # make sure we don't miss an interrupt # setting need_resched or sigpending - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |