lkml.org 
[lkml]   [2003]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 12/14] USB speedtouch: remove useless NULL pointer checks
Date
The stats field is never NULL.

speedtch.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)


diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed May 21 00:41:05 2003
+++ b/drivers/usb/misc/speedtch.c Wed May 21 00:41:05 2003
@@ -358,8 +358,7 @@

/* is skb long enough ? */
if (skb->len < pdu_length) {
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx_err);
+ atomic_inc (&ctx->vcc->stats->rx_err);
return NULL;
}

@@ -378,8 +377,7 @@
/* check crc */
if (pdu_crc != crc) {
dbg ("udsl_decode_aal5: crc check failed!");
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx_err);
+ atomic_inc (&ctx->vcc->stats->rx_err);
return NULL;
}

@@ -387,8 +385,7 @@
skb_trim (skb, length);

/* update stats */
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx);
+ atomic_inc (&ctx->vcc->stats->rx);

vdbg ("udsl_decode_aal5 returns pdu 0x%p with length %d", skb, skb->len);
return skb;
@@ -760,8 +757,7 @@
dev_kfree_skb (skb);
instance->current_skb = NULL;

- if (vcc->stats)
- atomic_inc (&vcc->stats->tx);
+ atomic_inc (&vcc->stats->tx);
}

goto made_progress;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.427 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site