Messages in this thread | | | From | Rusty Russell <> | Subject | Re: try_then_request_module | Date | Tue, 20 May 2003 10:19:00 +1000 |
| |
In message <20030519110832.G626@nightmaster.csn.tu-chemnitz.de> you write: > So try_then_request_module() will consolidate the the > branch or in the worst case just duplicating that code > everywhere (depends on wether you implement it as a non-inline > function or define).
I'm not speculating: here it is from kmod.h:
#define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x))
It really should be:
#ifdef CONFIG_KMOD #define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x)) #else #define try_then_request_module(x, mod...) (x) #endif /* CONFIG_KMOD */
Patches welcome.
Getting rid of the CONFIG_KMOD's in general code without leaving unused code around is the aim here.
Hope that clarifies! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |