Messages in this thread | | | Subject | Re: Resend [PATCH] Make KOBJ_NAME_LEN match BUS_ID_SIZE | From | Felipe Alfaro Solana <> | Date | 16 May 2003 20:43:02 +0200 |
| |
On Fri, 2003-05-16 at 02:20, Ben Collins wrote: > On Tue, May 13, 2003 at 08:08:35AM -0700, Patrick Mochel wrote: > > > > On Tue, 13 May 2003, Ben Collins wrote: > > > > > On Tue, May 13, 2003 at 08:10:32AM +0100, Christoph Hellwig wrote: > > > > On Tue, May 13, 2003 at 02:26:40AM -0400, Ben Collins wrote: > > > > > This was causing me all sorts of problems with linux1394's 16-18 byte > > > > > long bus_id lengths. The sysfs names were all broken. > > > > > > > > > > This not only makes KOBJ_NAME_LEN match BUS_ID_SIZE, but fixes the > > > > > strncpy's in drivers/base/ so that it can't happen again (atleast the > > > > > strings will be null terminated). > > > > > > > > What about defining BUS_ID_SIZE in terms of KOBJ_NAME_LEN? > > > > > > Ok, then add this in addition to the previous patch. > > > > I'll add this, and sync with Linus this week, if he doesn't pick it up. > > *sigh* Patrick, you accepted the BUS_ID_SIZE change without the original > patch, so now BUS_ID_SIZE is back to 16 bytes. > > Linus, please apply this patch to get things right again.
Well, it seems this patch has bad interaction with the Yamaha ALSA sound driver (aka snd-ymfpci). Don't know why, but changing KOBJ_NAME_LEN from 16 to 20, causes snd-ymfpci.ko to oops.
If you have the time, please take a look at another thread in the LKML called "pccard oops while booting".
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |