lkml.org 
[lkml]   [2003]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iphase fix.
Jeff Garzik wrote:
>> dev_kfree_skb(skb);
>> - else
>> - netif_wake_queue(dev);
>> + netif_wake_queue(dev);
>> LEAVE("iph5526_send_packet");
>
>
>
> This appears to revert a fix.
>
> You only want to wake the queue if you have room to queue another skb.


Actually, I'm wrong.

But it could still use some looking-at. You don't want to stop_queue at
the beginning of send_packet and wake_queue at the end. Instead, the
queue should be awakened in the Tx completion routine, and the
stop_queue should be moved from the beginning to the end of the function.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.042 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site