Messages in this thread |  | | Subject | Re: [PATCH][ATM] allow atm to be loaded as a module | Date | Thu, 15 May 2003 23:04:58 -0400 | From | chas williams <> |
| |
In message <20030515.164732.15245120.davem@redhat.com>,"David S. Miller" writes: >space and no compiler is going to do this rearrangement for you. >Yes, this means use gotos....
*sigh*. how about this -- its safe to always call the exit stubs. they just call sock_unregister which always suceeds. actually i see very few protocol families check the return code from sock_register() -- should i ignore the return code as well?
static int __init atm_init(void) { int error;
if ((error = atmpvc_init()) < 0) { printk(KERN_ERR "atmpvc_init() failed with %d\n", error); goto failure; } if ((error = atmsvc_init()) < 0) { printk(KERN_ERR "atmsvc_init() failed with %d\n", error); goto failure; } #ifdef CONFIG_PROC_FS if ((error = atm_proc_init()) < 0) { printk(KERN_ERR "atm_proc_init() failed with %d\n",error); goto failure; } #endif return 0;
failure: atmsvc_exit(); atmpvc_exit(); return error; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |