lkml.org 
[lkml]   [2003]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] PAG support only
Date
From

Christoph Hellwig wrote:

> Please split this into 2 lines as per Documentation/CodingStyle. Even better
> make vfs_token_put handle a NULL argument.

Done the latter.

> Random whitespace change

Gone.

> - and even a wrong one..

I disagree, but no matter.

> > +static kmem_cache_t *vfs_token_cache;
> > +static kmem_cache_t *vfs_pag_cache;
>
> How many of those will be around for a typical AFS client? I have the vague
> feeling the slabs are overkill..

And then there's the people who said I shouldn't use kmalloc but should create
a slab instead...

> > + if (pag>0) {
> > + /* join existing PAG */
> > + if (tsk->vfspag->pag &&
> > + tsk->vfspag->pag==pag)
> > + return pag;
>
> Please try to get your code in conformance with Documentation/CodingStyle.

You are suggesting what changes exactly?

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.125 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site