Messages in this thread | | | Date | Tue, 13 May 2003 22:46:25 -0700 | From | William Lee Irwin III <> | Subject | Re: ahc_linux_map_seg() compile/style/data corruption fixes |
| |
On Tue, May 13, 2003 at 10:37:47PM -0700, William Lee Irwin III wrote: > Hmm, 2.5.x is supposed to guarantee most (if not all) of the > preconditions the code here is trying to (re)establish. Probably the > only use of not ripping out the 4GB spanning code and segment count > checks is to keep driver versions synched. As it stands, this doesn't > compile and if ever invoked the code not needed for 2.5 will not behave > as expected (though thankfully a nop). Maybe a (shudder) #ifdef to rip > out the overhead for 2.5 should be added esp. as post gcc-3.0 probably > can't compile earlier kernels anyway.
Clarification: the code before my patch doesn't compile with gcc-3.3; the code after it does. Mutatis mutandis with respect to the unexpected behavior.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |