lkml.org 
[lkml]   [2003]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] PAG support, try #2
Date
From

> > +typedef __kernel_pag_t pag_t;
>
> > +static pag_t vfs_pag_next = 1;
>
> > + vfspag->pag = vfs_pag_next++;
> > + if (vfspag->pag < 1)
> > + vfspag->pag = 1;
>
> Is there a reason pag_t isn't an unsigned int? Seems to me you'll have
> 2^31 good times followed by 2^31 bad times. Also, isn't signed overflow
> one of these undefined things? I wouldn't mention it except that gcc
> seem to be more and more fond of obeying the letter of the standard
> rather than doing useful stuff.

I made it the same as pid_t. However, -ve PIDs can have special meanings which
aren't applicable to PAGs, so I suppose it ought to be unsigned. Time to
change it again. Sigh.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.168 / U:1.048 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site