[lkml]   [2003]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] PAG support, try #2
On Wed, May 14, 2003 at 11:43:31AM +0100, David Howells wrote:
> +typedef int __kernel_pag_t;

> +typedef __kernel_pag_t pag_t;

> +static pag_t vfs_pag_next = 1;

> + vfspag->pag = vfs_pag_next++;
> + if (vfspag->pag < 1)
> + vfspag->pag = 1;

Is there a reason pag_t isn't an unsigned int? Seems to me you'll have
2^31 good times followed by 2^31 bad times. Also, isn't signed overflow
one of these undefined things? I wouldn't mention it except that gcc
seem to be more and more fond of obeying the letter of the standard
rather than doing useful stuff.

"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:35    [W:2.006 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site