lkml.org 
[lkml]   [2003]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][ATM] make clip modular
Date
From
In message <20030512.132641.35021107.davem@redhat.com>,"David S. Miller" writes
:
> +#if defined(CONFIG_ATM_CLIP) || defined(CONFIG_ATM_CLIP_MODULE)
> case SIOCMKCLIP:
> if (!capable(CAP_NET_ADMIN))
> ret_val = -EPERM;
> else
> - ret_val = clip_create(arg);
> + ret_val = atm_clip_ops->clip_create(arg);
> goto done;
>
>Do you know that atm_clip_ops is non-NULL here? How is that?
>Also how can you legally call into a module without having a reference
>to it or somehow otherwise blocking it's unloading (f.e. by holding
>the ops semaphore)?

the rest of these ioctls need an interface to operate on. if the
clip module is removed, no clip interfaces. of course, this doesnt
prevent a malicous user from issuing the ioctl anyway. i have thought
about it. i suppose i could fix the rest of the clip troubles.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:1.311 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site