lkml.org 
[lkml]   [2003]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] 2.5.69-dj1: agp_init shouldn't be static
On Sun, May 11, 2003 at 02:51:48PM +0100, Christoph Hellwig wrote:
> On Sun, May 11, 2003 at 02:21:20PM +0100, Dave Jones wrote:
> > duhh, the 810 framebuffer needs it early. I forgot about that.
> > Will apply patch, and add a comment. Thanks.
>
> no, it doesn't need the agp banner printk early :) Fix i810fb instead.

Ahh crap, this may bring up another problem. The agpgart _has_ to be
initialised before the i810fb code, otherwise it won't work.
Now that agp_init() doesn't do anything useful, we're relying
on link order. Whether we get that right or not right now depends..
Needs to be tested by someone who actually uses i810fb to be sure.

Volunteers? (Just chop out the agp_init call in
drivers/video/i810/i810_main.c), oh and I'm only interested in
feedback from either users of 2.5.69-dj1, or 2.5 bitkeeper tree,
(Linus seems to have taken the first round of AGP updates in the last few hours).

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2011 Jasper Spaans