lkml.org 
[lkml]   [2003]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)
On Sat, May 10, 2003 at 09:52:49AM -0400, chas williams wrote:
> In message <20030510062015.A21408@infradead.org>,Christoph Hellwig writes:
> >> +init_one_failure:
> >> + if (atm_dev) atm_dev_deregister(atm_dev);
> >> + if (he_dev) kfree(he_dev);
> >> + pci_disable_device(pci_dev);
> >> + return err;
> >
> >kfree(NULL) if perfectly fine. Also please untangle all this if
> >statements to two separate lines.
>
> but its ok for usb drivers?

Not at all. I'll gladly take patches to fix this crud up.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.067 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site