Messages in this thread | | | Date | Sat, 10 May 2003 06:20:16 +0100 | From | Christoph Hellwig <> | Subject | Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) |
| |
On Fri, May 09, 2003 at 07:38:34PM -0400, chas williams wrote: > + > +init_one_failure: > + if (atm_dev) atm_dev_deregister(atm_dev); > + if (he_dev) kfree(he_dev); > + pci_disable_device(pci_dev); > + return err;
kfree(NULL) if perfectly fine. Also please untangle all this if statements to two separate lines.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |