Messages in this thread | | | Date | Tue, 8 Apr 2003 21:27:49 -0700 | From | Andrew Morton <> | Subject | Re: [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info |
| |
Roland Dreier <roland@topspin.com> wrote: > > Andrew, I've never seen a reply from you about this, can you tell me > if I'm missing something here? >
No, I agree. I don't think pending delayed work should contribute to the count at all.
If someone wants to synchronise with the workqueue system they should cancel any delayed work which they own (via cancel_scheduled_work) and then wait on any currently-queued works via flush_scheduled_work().
So flush_scheduled_work() only needs to care about currently-queued works, not the ones which are pending a timer event.
And flush_scheduled_work() needs to be taught to not lock up if someone keeps re-adding work.
That's what my patch did (I think; it was a quicky)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |