[lkml]   [2003]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68
    On Tue, 29 Apr 2003 22:15:20 +0000 Gabriel Devenyi <> wrote:

    | This patch applies to 2.5.68. It converts all the remaining error returns to
    | the new return -E form, this is in the KernelJanitor TODO list.
    | Please CC me with any discussion since I do not subscribe to lkml
    | --

    I'd have to say that it really depends on whether the caller can
    handle negative return values. Did you check/audit the callers too?

    If it's a well-defined Unix/Linux error code (like s/ENOMEM/-ENOMEM/),
    this should be made to work (at least in most cases).

    And don't change ones that use ERR_PTR, like this:

    - return ERR_PTR(-ENOMEM);
    + return -ENOMEM;

    Local variable returns of positive/negative are probably not correct...
    without auditing the callers, it's hard to say. E.g.:

    - return ErrFlag;
    + return -ErrFlag;

    (same type of change in DAC960 driver)

    I'm a bit suspicious of:

    - return EOF;
    + return -EOF;


    - return E05;
    + return -E05;

    It's not just a global search & replace...

    One more thing... did you build and boot that modified kernel?
    If so, did it build with the same number or fewer warnings than the
    unmodified version?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:35    [W:0.020 / U:0.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site