Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [linux-usb-devel] Re: [Bluetooth] HCI USB driver update. Support for SCO over HCI USB. | Date | Wed, 30 Apr 2003 00:24:26 +0200 |
| |
Am Dienstag, 29. April 2003 23:40 schrieb Greg KH: > On Tue, Apr 29, 2003 at 11:34:19PM +0200, Oliver Neukum wrote: > > > +int usb_init_urb(struct urb *urb) > > > +{ > > > + if (!urb) > > > + return -EINVAL; > > > + memset(urb, 0, sizeof(*urb)); > > > + urb->count = (atomic_t)ATOMIC_INIT(1); > > > + spin_lock_init(&urb->lock); > > > + > > > + return 0; > > > +} > > > > Greg, please don't do it this way. Somebody will > > try to free this urb. If the urb is part of a structure > > this must not lead to a kfree. Please init it to some > > insanely high dummy value in this case. > > We can't init it to a high value, if we want to use it ourself in > usb_alloc_urb().
So don't or make that value a parameter.
> And yes, I agree this is a very dangerous function to use on your own, > I thought I conveyed that in the documentation for the function.
It's not any more dangerous than what worked quite well for 2.4.
> But if we don't have such a function, then people like Max will just > roll their own, like he just did :) > > Might as well make it easy for him to shoot himself in the foot if he > really wants to...
Sure, why not.
Regards Oliver
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |