Messages in this thread | | | Subject | Re: [PATCH] Small bug fix for aio | From | Mingming Cao <> | Date | 24 Apr 2003 13:21:04 -0700 |
| |
On Wed, 2003-04-23 at 20:14, Benjamin LaHaise wrote: > On Tue, Apr 22, 2003 at 06:54:51PM -0700, Mingming Cao wrote: > > Here is a trivial patch fixed a bug in ioctx_alloc(). If > > aio_setup_ring() failed, ioctx_alloc() should pass the return error from > > aio_setup_ring() back to sys_io_setup(). > > This particular case was intentional: -ENOMEM really is the right return > code when the ring cannot be allocated. Mixing it up with the potential > return codes from do_mmap or other functions might result in a very > nonsensical return. Perhaps someone can provide an arguement in favour > of propagating the value, but I think it really can only mean "you asked > the kernel to allocate too much memory or did something stupidly buggy with > threads". Cheers, > > -ben
Ok, then I think -ENOMEM makes more sense. Thanks for clarifying.
Mingming
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |