Messages in this thread | | | Date | Thu, 24 Apr 2003 19:32:28 +0200 | From | Jens Axboe <> | Subject | Re: Badness in as-iosched:1210 |
| |
On Fri, Apr 25 2003, Nick Piggin wrote: > Jens Axboe wrote: > > >On Thu, Apr 24 2003, Nick Piggin wrote: > > > >>Zwane Mwaikambo wrote: > >> > >> > >>>I'm not sure wether you want this, it was during error handling from the > >>>HBA driver (source was disk error). > >>> > >>>scsi1: ERROR on channel 0, id 3, lun 0, CDB: Read (10) 00 00 7f de 60 00 > >>>00 80 00 Info fld=0x7fdeb2, Current sdd: sense key Medium Error > >>>Additional sense: Unrecovered read error > >>>end_request: I/O error, dev sdd, sector 8380032 > >>>Badness in as_add_request at drivers/block/as-iosched.c:1210 > >>> > >>> > >>Thanks I'll have a look. > >> > > > >The debug check looks broken, request could have come from somewhere > >else than the block pool. > > > Thats right. I thought these requests would all be > !blk_fs_request()s though. It should be only the debug > checks which are wrong.
Exactly, the rest looks ok, the debug trigger is wrong :). The add_request() strategy is the entry point for all types of requests, not just blk_fs_request()
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |