Messages in this thread | | | Date | Thu, 24 Apr 2003 11:25:08 -0400 | From | Chuck Ebbert <> | Subject | Re: [PATCH] 2.4.21-rc1 pointless IDE noise reduction |
| |
Jens Axboe wrote:
>> + return((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0); >> } > > Seconded, it causes a lot more confusion than it does good.
The return looks like a function call in that last line.
That's one of the few things I find really annoying -- extra parens are fine when they make code clearer, but not there.
------- Chuck [ C Style Police, badge #666 ] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |