lkml.org 
[lkml]   [2003]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.4.21-rc1 pointless IDE noise reduction
    On Thu, Apr 24 2003, Erik Andersen wrote:
    > The ide driver does not list whether drives support things like
    > write cache, SMART, SECURITY ERASE UNIT. But for some silly
    > reason it tells us at boot whether each drive is capable of
    > supporting the Host Protected Area feature set. If people want
    > to know the capabilites of their drive, they can run 'hdparm'
    > and find out.
    >
    > This patch removes this pointless noise. Please apply,
    >
    >
    > --- linux/drivers/ide/ide-disk.c.orig 2003-04-24 03:23:53.000000000 -0600
    > +++ linux/drivers/ide/ide-disk.c 2003-04-24 03:24:54.000000000 -0600
    > @@ -1133,10 +1133,7 @@
    > */
    > static inline int idedisk_supports_host_protected_area(ide_drive_t *drive)
    > {
    > - int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
    > - if (flag)
    > - printk("%s: host protected area => %d\n", drive->name, flag);
    > - return flag;
    > + return((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0);
    > }

    Seconded, it causes a lot more confusion than it does good.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.027 / U:58.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site