[lkml]   [2003]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] M68k IDE updates
    On Mon, 14 Apr 2003, Linus Torvalds wrote:
    > On Mon, 14 Apr 2003, Paul Mackerras wrote:
    > > Since __ide_mm_insw doesn't get told whether it is transferring normal
    > > sector data or drive ID data, it can't necessarily do the right thing
    > > in both situations.
    > Can we please then just separate the two functions out into "fetch sector
    > data" and "fetch drive ID"? And NOT playing with another frigging broken
    > passed-down flag that people get wrong and isn't obvious what it does
    > anyway? It's a lot easier to do
    > /* On sane architectures, data and ID are accessed the same */
    > #define ide_fetch_sector_data(...) __ide_fetch_data(..)
    > #define ide_fetch_id_data(...) __ide_fetch_data(..)
    > than it is to carry a flag around and having to remember to get it right
    > in every place this is used.

    OK, I took a closer look at the IDE identification innards.

    It's quite easy to call hwif->ata_input_id() instead of hwif->ata_input_data()
    for reading the drive ID. Then hwif->ata_input_id() can take care of the
    byteswapping for hardwired byteswapped IDE busses.

    However, there's also a routine that involves more magic:
    taskfile_lib_get_identify(). While trying to understand that one, I found more
    commands that should call the (possible byteswapping) hwif->ata_input_id()
    operations, like SMART commands. So first we need a clearer differentiation
    between commands that transfer on-platter data, or other drive data.

    Any comments from the IDE experts?



    Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:34    [W:0.022 / U:3.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site