Messages in this thread | | | Date | Fri, 18 Apr 2003 19:03:55 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] devfs (2/7) - minor miscdev changes |
| |
On Fri, Apr 18, 2003 at 09:29:00AM -0700, Roland Dreier wrote: > int misc_register(struct miscdevice * misc) > { > - static devfs_handle_t devfs_handle, dir; > struct miscdevice *c; > + char buf[256]; > > Wouldn't it be better not to have a 256-byte buffer on the stack?
You're probably right. But 64 bytes should be enough anyway - that's what devfs uses everywhere else.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |