lkml.org 
[lkml]   [2003]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.5.66-bk5 spinlock warnings/errors - Specifically ide-io:109 spinlock notice
Shawn Starr wrote:

>I'm going to apply this and see what happens, unless it was already added to
>.67-bk latest?
>
>
Alan included it into the -ac kernels, I guess he will forward it to Linus.

>>--- 2.5/drivers/ide/ide-io.c 2003-03-25 17:49:40.000000000 +0100
>>+++ build-2.5/drivers/ide/ide-io.c 2003-03-30 10:05:28.000000000 +0200
>>@@ -973,7 +973,7 @@
>>
>>
>> }
>>
+ wait = 0;

>> if ((expiry = hwgroup->expiry) != NULL) {
>> /* continue */
>>- if ((wait = expiry(drive)) != 0) {
>>+ if ((wait = expiry(drive)) > 0) {
>> /* reset timer */
>> hwgroup->timer.expires = jiffies + wait;
>> add_timer(&hwgroup->timer);
>>
This change was missing in my patch: wait was used without initialization.


--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [from the cache]
©2003-2011 Jasper Spaans