lkml.org 
[lkml]   [2003]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] dentry_stat fix
Maneesh Soni <maneesh@in.ibm.com> wrote:
>
> On Mon, Apr 14, 2003 at 02:14:48AM -0700, Andrew Morton wrote:
> > Maneesh Soni <maneesh@in.ibm.com> wrote:
> > >
> > > This patch the corrects the dentry_stat.nr_unused calculation.
> >
> > OK, I didn't even know we had a bug in there...
> >
> > btw, can you explain to me why shrink_dcache_anon() and select_parent() are
> > putting dentries at the wrong end of dentry_unused?
> prune_dcache() picks up from this end in first round. It will reset the
> DCACHE_REFERENCED flag and will put it to the front of dentry_unused list.
>

Sorry, but I still don't understand why they're being put at the "oldest" end
of dentry_unused.

Also, shrink_dcache_anon() does:

prune_dcache(found);

I hope we're not assuming that all the dentries which were just added will be
freed? They hae the referenced bit set, and new dentries can be added...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.368 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site