lkml.org 
[lkml]   [2003]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.5.67: ppa driver & preempt == oops
    Gert Vervoort <gert.vervoort@hccnet.nl> wrote:
    >
    > ppa: Version 2.07 (for Linux 2.4.x)
    > ppa: Found device at ID 6, Attempting to use EPP 16 bit
    > ppa: Communication established with ID 6 using EPP 16 bit
    > scsi0 : Iomega VPI0 (ppa) interface
    > bad: scheduling while atomic!

    This patch should make the warnings go away.

    I've been sitting on it for a while, waiting for someone to tell me if the
    ppa driver actually works. Perhaps that person is you?


    diff -puN drivers/scsi/ppa.c~ppa-null-pointer-fix drivers/scsi/ppa.c
    --- 25/drivers/scsi/ppa.c~ppa-null-pointer-fix 2003-03-23 16:08:37.000000000 -0800
    +++ 25-akpm/drivers/scsi/ppa.c 2003-03-23 16:09:14.000000000 -0800
    @@ -219,13 +219,15 @@ int ppa_detect(Scsi_Host_Template * host
    printk(" supported by the imm (ZIP Plus) driver. If the\n");
    printk(" cable is marked with \"AutoDetect\", this is what has\n");
    printk(" happened.\n");
    - spin_lock_irq(hreg->host_lock);
    + if (hreg) /* This is silly */
    + spin_lock_irq(hreg->host_lock);
    return 0;
    }
    try_again = 1;
    goto retry_entry;
    } else {
    - spin_lock_irq(hreg->host_lock);
    + if (hreg) /* And this should be unnecessary */
    + spin_lock_irq(hreg->host_lock);
    return 1; /* return number of hosts detected */
    }
    }
    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.021 / U:30.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site