Messages in this thread | | | Date | Tue, 1 Apr 2003 12:11:46 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: PATCH: allow percentile size of tmpfs (2.5.66 / 2.4.20-pre2) |
| |
On 1 Apr 2003, Xavier Bestel wrote: > size = memparse(value,&rest); > + if (*rest == '%') { > + struct sysinfo si; > + si_meminfo(&si); > + size = (si.totalram << PAGE_CACHE_SHIFT) / 100 * size; > > (si.totalram << PAGE_CACHE_SHIFT) * size / 100; > would have been better precision-wise.
Hardly, it'll overflow in even more cases than CaT's (si.totalram << PAGE_CACHE_SHIFT). I'll take a look at this later, not right now.
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |