[lkml]   [2003]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] small fixes in brlock.h
On Sun, 2003-03-09 at 18:44, Zwane Mwaikambo wrote:

> #define br_read_unlock_irqrestore(idx, flags) \
> - do { br_read_unlock(irx); local_irq_restore(flags); } while (0)
> + do { br_read_unlock(idx); local_irq_restore(flags); } while (0)

BTW, I am amazed all these s/idx/irx/ bugs exist and no one noticed

I guess nothing uses these irq variants. In fact, grepping the
source... wow, not much uses brlocks at all. Only registered lock is
BR_NETPROTO_LOCK. A read lock on it is called only 7 times and a write
lock is used 31 times.

Everything must of moved over to using RCU or something. It makes me
question the future of these things.

Robert Love

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean