lkml.org 
[lkml]   [2003]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20
    Hi!

    > >
    > > - if (!urb->status & !acm->throttle) {
    > > + if (!urb->status && !acm->throttle) {
    > > for (i = 0; i < urb->actual_length && !acm->throttle; i++) {

    > To summarize, I'd probably not be amused if you would change any of my
    > code which takes advantage of such programming finess. I would probably
    > have added appropriate comments to explain the code but nevertheless,
    > replacing the more efficient code with some which is easier to
    > understand should probably be considered on a case by case basis.

    Actually I feel co-responsible for acm.c,
    and this *is* typo. acm is for modems,
    thats *not* performance critical, and certainly
    not worth code obfuscation.
    --
    Pavel
    Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.019 / U:148.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site