lkml.org 
[lkml]   [2003]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.5.64 2/2] i_size atomic access
Daniel McNeil <daniel@osdl.org> wrote:
>
> This adds i_seqcnt to inode structure and then uses i_size_read() and
> i_size_write() to provide atomic access to i_size.

Ho hum. Everybody absolutely hates this, but I guess we should do it :(

> +static inline void i_size_write(struct inode * inode, loff_t i_size)
> +{
> +#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
> + write_seqcntbegin(&inode->i_size_seqcnt);
> + inode->i_size = i_size;
> + write_seqcntend(&inode->i_size_seqcnt);
> +#elif BITS_PER_LONG==32 && defined(CONFIG_PREMPT)
> + prempt_disable();
> + inode->i_size = i_size;
> + prempt_enable();
> +#else
> + inode->i_size = i_size;
> +#endif
> +}

You've used "PREMPT" and "prempt" throughput the patch. It is in fact
"PREEMPT" and "preempt".

Could you please fix that up and send me fresh copies? Probably as
attachments - your mailer wordwrapped the patches.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.057 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site