lkml.org 
[lkml]   [2003]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scsi_error fix
James Bottomley [James.Bottomley@steeleye.com] wrote:

> @@ -702,8 +701,14 @@
> * if the result was normal, then just pass it along to the
> * upper level.
> */
> - if (rtn == SUCCESS)
> + if (rtn == SUCCESS) {
> + /* we don't want this command reissued, just
> + * finished with the sense data, so set
> + * retries to the max allowed to ensure it
> + * won't get reissued */
> + scmd->retries = scmd->allowed;
> scsi_eh_finish_cmd(scmd, done_q);
> + }
> if (rtn != NEEDS_RETRY)
> continue;
>

We might need to cover the case down below if we succeed on retry without
reaching allowed.

Another option is to look into re-sending the command from the
scsi_queue_insert handler like we do with timeouts. The interface to the
device should be the same from the LLDD's point of view just delayed
some.


-andmike
--
Michael Anderson
andmike@us.ibm.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.062 / U:3.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site