lkml.org 
[lkml]   [2003]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectPOSIX timer syscalls
    Syscall stubs must be declared to return "long", to ensure things work
    properly on all 64-bit platforms (see earlier discussion on this
    topic). Patch below.

    On a related note: as far as I can see, timer_t is declared as "int"
    on all platforms (both by kernel and glibc). Yet if my reading of the
    kernel code is right, it's supposed to be "long" (and allegedly some
    standard claims that timer_t should be the "widest" integer on a
    platform). But then again, I'm not familiar with the POSIX timer
    interface myself, so perhaps I'm completely off base here.

    --david

    diff -Nru a/kernel/posix-timers.c b/kernel/posix-timers.c
    --- a/kernel/posix-timers.c Thu Mar 6 14:59:46 2003
    +++ b/kernel/posix-timers.c Thu Mar 6 14:59:46 2003
    @@ -423,7 +423,7 @@

    /* Create a POSIX.1b interval timer. */

    -asmlinkage int
    +asmlinkage long
    sys_timer_create(clockid_t which_clock,
    struct sigevent *timer_event_spec, timer_t * created_timer_id)
    {
    @@ -663,7 +663,7 @@
    }
    }
    /* Get the time remaining on a POSIX.1b interval timer. */
    -asmlinkage int
    +asmlinkage long
    sys_timer_gettime(timer_t timer_id, struct itimerspec *setting)
    {
    struct k_itimer *timr;
    @@ -695,7 +695,7 @@

    */

    -asmlinkage int
    +asmlinkage long
    sys_timer_getoverrun(timer_t timer_id)
    {
    struct k_itimer *timr;
    @@ -848,7 +848,7 @@
    }

    /* Set a POSIX.1b interval timer */
    -asmlinkage int
    +asmlinkage long
    sys_timer_settime(timer_t timer_id, int flags,
    const struct itimerspec *new_setting,
    struct itimerspec *old_setting)
    @@ -922,7 +922,7 @@
    }

    /* Delete a POSIX.1b interval timer. */
    -asmlinkage int
    +asmlinkage long
    sys_timer_delete(timer_t timer_id)
    {
    struct k_itimer *timer;
    @@ -1054,7 +1054,7 @@
    return -EINVAL;
    }

    -asmlinkage int
    +asmlinkage long
    sys_clock_settime(clockid_t which_clock, const struct timespec *tp)
    {
    struct timespec new_tp;
    @@ -1069,7 +1069,7 @@
    new_tp.tv_nsec /= NSEC_PER_USEC;
    return do_sys_settimeofday((struct timeval *) &new_tp, NULL);
    }
    -asmlinkage int
    +asmlinkage long
    sys_clock_gettime(clockid_t which_clock, struct timespec *tp)
    {
    struct timespec rtn_tp;
    @@ -1088,7 +1088,7 @@
    return error;

    }
    -asmlinkage int
    +asmlinkage long
    sys_clock_getres(clockid_t which_clock, struct timespec *tp)
    {
    struct timespec rtn_tp;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.023 / U:64.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site