lkml.org 
[lkml]   [2003]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] move SWAP option in menu
On Thu, Mar 06, 2003 at 11:43:32AM -0700, Tom Rini wrote:
>
> How's this look? I picked MMU=x implies SWAP=x for defaults, just
> because that's how they were before...

I'd be very surprised if it were possible to have swap on a MMU-less
machine (no virtual memory, page faults, etc.). Except for this nitpick,
the patch looks fine, but my knowledge of MM is close to zero (and
also of the new config language, but I'll have to learn it soon).

> ===== init/Kconfig 1.10 vs edited =====
> --- 1.10/init/Kconfig Mon Feb 3 13:19:37 2003
> +++ edited/init/Kconfig Thu Mar 6 11:41:51 2003
> @@ -37,6 +37,16 @@
>
> menu "General setup"
>
> +config SWAP
> + bool "Support for paging of anonymous memory"
> + default y if MMU
> + default n if !MMU

Should rather be (from just reading kconfig-language.txt):

config SWAP
depends on MMU
bool "Support for paging of anonymous memory"
default y

Comments?

Gabriel.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.071 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site