lkml.org 
[lkml]   [2003]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH]Fix to the new sysfs bin file support
From
Date
I happen to notice the new binary file support in sysfs and had to take
for a spin. If I understand this correct my write file will need to
allocate the buffer->data, but then I have no way of freeing that memory
since I don't get a release callback.

Here is a patch that:
* makes sysfs cleanup the buffer->data allocated by the attribute write
functions
* fixes a bug that causes the kernel to oops when somebody attempts to
write to the file.

BTW, would you be totally opposed to a patch that added open, release,
and ioctl to the list of functions supported by sysfs binary files?

Another question... How would a driver know that the various write and
read calls are coming from the same open, or would there be a way for a
driver to make it so that only one thing can open the sysfs file at a
time?
--rustyl

--- fs/sysfs/bin.c.orig 2003-03-05 18:33:44.000000000 -0800
+++ fs/sysfs/bin.c 2003-03-05 18:34:01.000000000 -0800
@@ -50,6 +50,10 @@
ret = count;
}
Done:
+ if (buffer && buffer->data) {
+ kfree(buffer->data);
+ buffer->data = NULL;
+ }
return ret;
}

@@ -66,7 +70,7 @@
static int fill_write(struct file * file, const char * userbuf,
struct sysfs_bin_buffer * buffer)
{
- return copy_from_user(buffer,userbuf,buffer->count) ?
+ return copy_from_user(buffer->data,userbuf,buffer->count) ?
-EFAULT : 0;
}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.054 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site