lkml.org 
[lkml]   [2003]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.5.63/64 do not boot: loop in scsi_error

    On Thu, 6 Mar 2003 Andries.Brouwer@cwi.nl wrote:
    >
    > See that 2.5.64 came out - good. Time to send the next dev_t patch.
    > Unfortunately 2.5.63 and 2.5.64 do not boot.
    >
    > A moment ago I looked at what goes wrong, and it turns out that
    > scsi_error is activated

    See if this fixes it..

    Linus

    ---
    # This is a BitKeeper generated patch for the following project:
    # Project Name: Linux kernel tree
    # This patch format is intended for GNU patch command version 2.5 or higher.
    # This patch includes the following deltas:
    # ChangeSet 1.1088 -> 1.1089
    # drivers/scsi/scsi_error.c 1.38 -> 1.39
    #
    # The following is the BitKeeper ChangeSet Log
    # --------------------------------------------
    # 03/03/05 andmike@us.ibm.com 1.1089
    # [PATCH] Fix SCSI error handler abort case
    #
    # I had my list empty checks reversed if aborting and bus device reset
    # failed. The condition that causes the error handler to run is still
    # unknown.
    # --------------------------------------------
    #
    diff -Nru a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
    --- a/drivers/scsi/scsi_error.c Wed Mar 5 17:21:56 2003
    +++ b/drivers/scsi/scsi_error.c Wed Mar 5 17:21:56 2003
    @@ -1490,9 +1490,9 @@
    struct list_head *work_q,
    struct list_head *done_q)
    {
    - if (scsi_eh_bus_device_reset(shost, work_q, done_q))
    - if (scsi_eh_bus_reset(shost, work_q, done_q))
    - if (scsi_eh_host_reset(work_q, done_q))
    + if (!scsi_eh_bus_device_reset(shost, work_q, done_q))
    + if (!scsi_eh_bus_reset(shost, work_q, done_q))
    + if (!scsi_eh_host_reset(work_q, done_q))
    scsi_eh_offline_sdevs(work_q, done_q);
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.022 / U:63.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site